Update Label.updated_by_user_id to be not required #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicksnyder
changed the title
|
I think you also need (buf.validate.field).ignore = IGNORE_IF_UNPOPULATEDWithout this, the default value (empty string) fails validation. We will want to update |
saquibmian
approved these changes
Apr 25, 2024
bufdev
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can get deleted. This is consistent with the behavior already documented for Commit.created_by_user_id
registry-proto/buf/registry/module/v1/commit.proto
Lines 62 to 65 in 5a40a3f