[Do not merge] Prototype new GitHub workflows for push++ #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicksnyder
commented
Apr 30, 2024
| run: buf format --diff --exit-code --error-format github-actions | ||
| - name: buf lint | ||
| run: buf lint --error-format github-actions | ||
| - name: buf push |
There was a problem hiding this comment.
as currently implemented, push doesn't happen on a branch if build, format, or lint fail
There was a problem hiding this comment.
do we want to push even if lint and build fail?
nicksnyder
commented
Apr 30, 2024
Comment on lines
+12
to
+13
| version: 1.32.0-beta.1 # remove this flag when 1.32.0 is released so we go back to always tracking latest. | ||
| # todo: use .bufversion or the env variable? |
There was a problem hiding this comment.
this line could be deleted if the action already supported .bufversion, which is in the proposal, but not implemented by the current action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a draft PR so it is easy to have discussions about and to inform decisions we are making with the unified GitHub action project.