Use buf-action in CI #115
Merged
Use buf-action in CI #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates CI to use the new `buf-action` replacing `buf-setup`, `buf-lint`, `buf-breaking` and `buf-push` unifying these tasks as one. The new behaviour is as follows: - On pull_requests: run lint, format and breaking change detection checks. - On push to main: push the changes of the latest commit with the label of the current branch (main). The following changes were made to support the new aciton: - The file `.bufversion` at the repository root now controls the version. This is read by both the Makefile and the action to fetch the correct version of buf. - Checks no longer block pushes of commits to the BSR. - Formatting checks have been added to `buf-ci.yaml`.
|
The latest Buf updates on your PR.
|
emcfarlane
commented
Jun 3, 2024
.github/workflows/buf-ci.yaml
Outdated
| @@ -0,0 +1,18 @@ | |||
| name: buf | |||
There was a problem hiding this comment.
File renamed for improved support for IDEs as buf.yaml will validate the file as a buf configuration file rather than a GitHub actions workflow file.
emcfarlane
commented
Jun 3, 2024
emcfarlane
commented
Jun 3, 2024
bufdev
reviewed
Jun 3, 2024
bufdev
reviewed
Jun 3, 2024
|
PR description needs an update based on changes from review comments (e.g. |
nicksnyder
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
This is what I would expect, but should wait for @bufdev to approve too.
bufdev
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates CI to use the new
buf-actionreplacingbuf-setup,buf-lint,buf-breakingandbuf-pushunifying these tasks as one. The new behaviour is as follows:Change in behaviour:
1.32.2, the current latest release.buf-ci.yaml.