Add 'buf format' #70
Merged
Add 'buf format' #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amckinney
commented
Mar 30, 2022
amckinney
commented
Mar 30, 2022
src/formatter.ts
Outdated
|
|
||
| // Use spawn instead of exec to avoid maxBufferExceeded error | ||
| const p = cp.spawn(this.binaryPath, [document.fileName], { cwd }); | ||
| // TODO: We need to use the CancellationToken. |
Since buf doesn't yet support reading from stdin for formatting, this require some hacky work around of temporary files.
amckinney
commented
Apr 5, 2022
|
If we add support for |
|
Looks great - as long as you've verified this all works locally (i.e. formatting on save). I can't stamp because I'm the original author, but feel free to approve on your end (as a formality on my behalf) and we can merge from there. After this lands, we can create an issue here that says to adapt the implementation to using stdin with that feature exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
DocumentFormattingEditProviderthat addsbuf formatto the extension.A lot of the code here is referenced from Go's old
goFormat.ts.