Switch to wlr scene-graph #50

ghost · 2021-10-30T16:13:07Z

~~It is still far from done, but apart from (not) raising view on focus it should be at least usable.~~

~~Depends on #44 (current commits from there are included) and wlroots 0.15 release.~~

TODOs –

whatever’s a TODO in the code
use the scene as much as possible (e.g. cursor focus, though that may require further progress of wlroots too)
WONTDO don’t make assumptions about new scene nodes (z-index, en/disabled…)
get rid of state duplication between the scene and kiwmi structs (positioning etc)
test it
LATER maybe provide replacements for view pre/post-render – but it might be saner to keep for later

heavyrain266 · 2021-10-30T18:34:31Z

Definitely looks interesting, not sure what convinced them to use stuff from gamedev and vector graphics editors in 2d linux and bsd desktops though, Scene-graph is widely used practice in game engines and programs in style of Adobe Illustrator to easier view data structure, mayby it makes sense for them 🤔.

ghost · 2021-11-13T20:31:42Z

~~6bd805c doesn’t fix the problem i thought it would fix (TODO: remove it, no need to move to another PR).~~ Oh wait, for some reason i built kiwmi with 9c3adf0, which of course doesn’t tell me if the later commit fixed it. I can’t seem to reproduce the crash the usual way, now that i build at the right commit.

~~I’m not very motivated to write any code at all these days, but i hope i’ll get into it again soon enough.~~

Here’s a basic-tasks checklist i’ve managed to think of; pls let me know / edit if you come up with something more.

scene
- created and destroyed
- bound to output layout
strata
- created
- correctly sorted
- destroyed (automatically on scene destroy)
output
- nodes created and destroyed
  - shouldn’t segfault with outputs destroyed later than the desktop
- nodes moved when moving
  - test this thing
view
- node created and destroyed
- initially hidden, ideally bottom-most in the stratum
- surface geom updated in scene (and it must be correct) – may be handled by wlr later
- node moved when moving
- unmaps when unmapped / hidden
- subsurfaces handled correctly (should be done by wlroots)
layer
- node created and destroyed
- node moved when moving
- node reparented on layer change
- (un)mapping correctly handled
popup
- node created
- node destroyed (by wlroots)
- node moved when moving (handled by wlroots)
- correctly unconstrained
- NOT re-unconstrained¹ (for xdg-shell v3, ref 039f990)
bg color
- node (rect) created and destroyed (automatically on scene destroy)
- node resized (and moved?) according to output layout
- changed on user request (kiwmi:bg_color)
- what about direct scanout (which will be automatically blocked by the scene_rect)? should we bother with it?
- pure black → rect is hidden (should black be the default?)
not required for merge (IMO)
- an alternative to view:pre/post_render

From the xdg-shell protocol:

For version 2 or older, the configure event for an xdg_popup is only ever sent once for the initial configuration. Starting with version 3, it may be sent again if the popup is setup with an xdg_positioner with set_reactive requested, or in response to xdg_popup.reposition requests.

…and version 3+ is currently not supported by wlroots (there is wlroots!3514 for wlr 0.16)

kiwmi/desktop/desktop.c

include/desktop/desktop.h

include/desktop/toplevel.h

include/desktop/output.h

ghost · 2021-12-20T20:10:11Z

kiwmi/desktop/view.c

+// why does it have to be unsigned? and why can it be negative, then?
 view_set_pos(struct kiwmi_view *view, uint32_t x, uint32_t y)


Unrelated, but this has been a mystery for me. Could you explain please?

kiwmi/input/cursor.c

ghost · 2021-12-22T21:30:50Z

Cleaned up the commit history so that it should now be easier to understand. However, there are still things to be done (see checklist in PR description).

kiwmi/desktop/view.c

kiwmi/desktop/layer_shell.c

include/desktop/toplevel.h

ghost · 2022-04-03T12:12:47Z

This force-push is mostly renaming stuff and moving commits around iirc; there should be no real changes.

ghost · 2022-04-15T12:19:30Z

~~I’m planning only one change (plus the two minor TODOs somewhere in the code), namely getting rid of view::hidden.~~ ~~Just one TODO-question is left (it’s got a thread open somewhere above), can you pls help me decide on it?~~

The PR is ready for review, and if everything is okay, also for merge.

ghost · 2022-05-08T10:25:47Z

This force-push is mostly splitting commits; only minimal changes.

ghost · 2022-05-08T10:48:48Z

include/desktop/stratum.h

+    KIWMI_STRATUM_LS_TOP,
+    KIWMI_STRATUM_LS_OVERLAY,
+    KIWMI_STRATUM_POPUPS,


Other compositors have top, normal popups, fulscreen, overlay, overlay popups, but since kiwmi doesn’t support client-initiated fulscreen, i left it like this.

(This is just a note for later ig.)

include/desktop/desktop_surface.h

Also handle NULL output in output_damage(). Co-authored-by: Uks2 <tom@tomg.xyz>

This is a preparation for switching to the wlroots scene-graph. There is no replacement planned for output:redraw() because it will no longer be necessary (as far as i can tell), while scene-compatible replacements for the view pre_render/post_render events are planned.

With the migration to wlr_scene, some objects (desktop, output etc) will no longer have any reason to care about individual shells and similar; handling each one on its own would introduce code that is, from their perspective, over-complicated. Strata (sg. stratum; this name was chosen to avoid confusion with the over-used 'layer') represent logical layers of surfaces on the desktop, such as every layer shell layer, one for xdg shell, another for popups.

At the moment it isn't used at all and a lot of data is duplicated. This is a temporary state introduced for nicer diff separation into several commits.

Apart from removing a lot of code, this commit also introduces (thanks to wlr_scene) fine-grained damage tracking. The lack of our own rendering code will only be an issue if the need for custom effects (such as blur) arises; however, that's very unlikely and it would probably require a lot of changes anyway.

Use it for getting the surface under cursor, position of surfaces, etc.

buffet · 2022-07-30T20:49:59Z

Thank you very much!

ghost commented Nov 16, 2021

View reviewed changes

kiwmi/desktop/desktop.c Outdated Show resolved Hide resolved

ghost commented Dec 20, 2021

View reviewed changes

ghost mentioned this pull request Dec 22, 2021

Update for wlroots 0.15 #44

Merged

ghost mentioned this pull request Jan 5, 2022

Doesn't build #56

Closed

ghost commented Jan 5, 2022

View reviewed changes

kiwmi/desktop/view.c Outdated Show resolved Hide resolved

ghost commented Jan 18, 2022

View reviewed changes

kiwmi/desktop/layer_shell.c Show resolved Hide resolved

ghost commented Mar 6, 2022

View reviewed changes

include/desktop/toplevel.h Outdated Show resolved Hide resolved

ghost marked this pull request as ready for review April 15, 2022 13:17

ghost commented May 8, 2022

View reviewed changes

ghost mentioned this pull request May 29, 2022

Expose wlr_scene to the config #60

Open

ghost mentioned this pull request Jun 20, 2022

Add wlr_output_manager support #62

Open

Uks2 mentioned this pull request Jun 21, 2022

Add set-title events for views #63

Open

buffet approved these changes Jul 25, 2022

View reviewed changes

include/desktop/desktop_surface.h Outdated Show resolved Hide resolved

tiosgz and others added 10 commits July 30, 2022 19:06

output: While destroying, destroy layers

398e0f1

Also handle NULL output in output_damage(). Co-authored-by: Uks2 <tom@tomg.xyz>

Keep an up-to-date wlr scene-graph

f144eb1

At the moment it isn't used at all and a lot of data is duplicated. This is a temporary state introduced for nicer diff separation into several commits.

Prefer wlr_scene as the source of truth

b82e612

Use it for getting the surface under cursor, position of surfaces, etc.

Move popup unconstraining logic

a8a8282

Cleanup unneeded code after switching to wlr_scene

ac0f6b7

Support protocols made easy by wlr_scene

8dcfffb

(Un)focus logic improvements

37312b9

buffet merged commit 1781497 into buffet:master Jul 30, 2022

ghost deleted the wlr-scene branch July 30, 2022 21:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to wlr scene-graph #50

Switch to wlr scene-graph #50

ghost commented Oct 30, 2021 •

edited by ghost

Loading

heavyrain266 commented Oct 30, 2021

ghost commented Nov 13, 2021 •

edited by ghost

Loading

ghost Dec 20, 2021 •

edited by ghost

Loading

ghost commented Dec 22, 2021

ghost commented Apr 3, 2022

ghost commented Apr 15, 2022 •

edited by ghost

Loading

ghost commented May 8, 2022

ghost May 8, 2022

buffet commented Jul 30, 2022

		// why does it have to be unsigned? and why can it be negative, then?
		view_set_pos(struct kiwmi_view *view, uint32_t x, uint32_t y)

Switch to wlr scene-graph #50

Switch to wlr scene-graph #50

Conversation

ghost commented Oct 30, 2021 • edited by ghost Loading

heavyrain266 commented Oct 30, 2021

ghost commented Nov 13, 2021 • edited by ghost Loading

ghost Dec 20, 2021 • edited by ghost Loading

Choose a reason for hiding this comment

ghost commented Dec 22, 2021

ghost commented Apr 3, 2022

ghost commented Apr 15, 2022 • edited by ghost Loading

ghost commented May 8, 2022

ghost May 8, 2022

Choose a reason for hiding this comment

buffet commented Jul 30, 2022

ghost commented Oct 30, 2021 •

edited by ghost

Loading

ghost commented Nov 13, 2021 •

edited by ghost

Loading

ghost Dec 20, 2021 •

edited by ghost

Loading

ghost commented Apr 15, 2022 •

edited by ghost

Loading