refactor: move CliChannel, add newtype IDs, restrict visibility#279
Merged
refactor: move CliChannel, add newtype IDs, restrict visibility#279
Conversation
R5.1: move CliChannel from zeph-core to zeph-channels/src/cli.rs R5.2: deferred (zeph-memory->zeph-llm dependency is functional, not just embedding) R6.1: introduce ConversationId/MessageId newtypes in zeph-memory with sqlx::Type R7.1: restrict internal helpers to pub(crate) across zeph-skills, zeph-index, zeph-memory 1351 tests pass, clippy clean. Closes #273, closes #274
github-actions
bot
added
skills
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 80.36% 80.40% +0.04%
==========================================
Files 94 96 +2
Lines 23718 23780 +62
==========================================
+ Hits 19060 19120 +60
- Misses 4658 4660 +2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CliChannelfrom zeph-core tozeph-channels/src/cli.rs— proper crate layeringzeph-memory→zeph-llmdependency is functional (uses Message/Role too)ConversationId(i64)andMessageId(i64)newtypes withsqlx::Type(transparent)pub(crate)restrictions on internal helpers in zeph-skills, zeph-index, zeph-memoryTest plan
cargo nextest run --workspace --lib --bins— 1351 passedcargo clippy --workspace -- -D warnings— zero warningsPhase 4 of #268. Closes #273, closes #274.