refactor: replace anyhow with typed AgentError in agent module#295
Merged
refactor: replace anyhow with typed AgentError in agent module#295
Conversation
Introduce AgentError enum with 7 variants (Llm, Channel, Memory, Skill, Tool, Io, Other) replacing anyhow::Result across all agent submodules. Only run() retains anyhow::Result as the boundary to main.rs. All error conversions use #[from] derives for zero-cost moves.
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (41.09%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #295 +/- ##
==========================================
- Coverage 80.03% 79.96% -0.07%
==========================================
Files 98 98
Lines 23926 23964 +38
==========================================
+ Hits 19149 19163 +14
- Misses 4777 4801 +24
🚀 New features to boost your workflow:
|
github-actions
bot
added
documentation
Bump workspace version 0.9.5 -> 0.9.6 with internal crate deps 0.9.4 -> 0.9.6. Update CHANGELOG, README, and mdBook docs to reflect epic #282 refactoring: typed errors, agent decomposition, field grouping, qdrant feature gating.
bug-ops
force-pushed
the
feat/m20/refactor-v2-phase4
branch
from
83fa180 to
4619174
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentErrorenum with 7 variants:Llm,Channel,Memory,Skill,Tool,Io,Otheranyhow::ResultwithResult<T, AgentError>across all agent submodulesrun()retainsanyhow::Resultas boundary to main.rs#[from]derives for zero-cost movesAgentErrorfromzeph_corecrate rootCloses #293
Part of #282
Test plan