refactor: remove TuiError, use ChannelError directly#302
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #302 +/- ##
=======================================
Coverage 79.96% 79.97%
=======================================
Files 98 98
Lines 23959 23961 +2
=======================================
+ Hits 19160 19162 +2
Misses 4799 4799
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
bug-ops
force-pushed
the
refactor/consolidate-tui-error
branch
from
5ca1b06 to
b899356
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zeph-tui::TuiErrorwhich duplicatedzeph-core::ChannelErrorvariantsChannelErrorfrom zeph-core directly in TUI terminal helpersCloses #297