add canonical path validation to skill loader#322
Merged
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 80.32% 80.32% -0.01%
==========================================
Files 99 99
Lines 24053 24099 +46
==========================================
+ Hits 19321 19357 +36
- Misses 4732 4742 +10
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
5feefca to
2737b2b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_path_withinto skill loader that canonicalizes paths and verifies they stay within the skills base directorySkillRegistry::loadbefore reading skill metadata, rejecting symlinks that escape the skills directoryCloses #307
Test plan
cargo nextest run -p zeph-skills— 67 tests passcargo clippy --workspace -- -D warnings— clean