detect relative path traversal in shell sandbox#325
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 80.32% 80.35% +0.03%
==========================================
Files 99 99
Lines 24099 24152 +53
==========================================
+ Hits 19357 19408 +51
- Misses 4742 4744 +2
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Extend sandbox validation to detect relative paths (./, ../, ..) and reject any path containing .. traversal segments before canonicalization. Also resolves pre-existing build issue by adding tokio macros feature to zeph-tools dependencies. Closes #308
bug-ops
force-pushed
the
feat/m14/shell-sandbox-relative
branch
from
9919354 to
cfb32fd
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_sandboxto detect relative paths (./,../,..) in addition to absolute paths..traversal segments before canonicalization to prevent sandbox escapetokio/macrosto zeph-tools dependencies (fixes pre-existing build issue withtokio::select!)Test plan
has_traversaldetectionextract_pathswith relative path extraction../,..,./outside allowed paths..traversalCloses #308