fix: add catch-all Allow rule to legacy permission policy#334
Merged
Conversation
from_legacy() created rules only for blocked commands (Deny) and confirm patterns (Ask) but lacked a fallback. Since check() defaults to Ask when no rule matches, every safe command (find, ls, echo, etc.) triggered a confirmation prompt that appeared to hang after approval. Append a wildcard Allow rule so unmatched commands execute without confirmation.
github-actions
bot
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #334 +/- ##
=======================================
Coverage 80.28% 80.28%
=======================================
Files 99 99
Lines 24236 24241 +5
=======================================
+ Hits 19458 19463 +5
Misses 4778 4778
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PermissionPolicy::from_legacy()lacked a fallback rule, causingcheck()to returnAskfor any command not inblocked_commandsorconfirm_patternsfind,ls,echotriggered confirmation prompts that appeared unresponsive after approvalAllowrule at the end of the legacy rule chain so unmatched commands execute without confirmationTest plan
findandlsreturnAllowviafrom_legacy