fix: implement execute_tool_call for WebScrapeExecutor#343
Merged
Conversation
WebScrapeExecutor only implemented the legacy text-extraction path, returning Ok(None) for native tool_use calls. Extract shared scrape_instruction helper and wire it into execute_tool_call.
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (23.68%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #343 +/- ##
==========================================
- Coverage 79.23% 79.18% -0.06%
==========================================
Files 99 99
Lines 25406 25431 +25
==========================================
+ Hits 20131 20137 +6
- Misses 5275 5294 +19
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execute(), returningOk(None)for nativeexecute_tool_call()— makingweb_scrapetool silently fail under native tool_use pathscrape_instruction()helper, wire into bothexecute()andexecute_tool_call()Test plan
cargo clippy -p zeph-tools -- -D warningspassescargo nextest run -p zeph-tools --lib— 240 tests pass