feat: output filter architecture improvements (M26.1)#452
Merged
Conversation
github-actions
bot
added
enhancement
bug-ops
force-pushed
the
feat/m26.1/output-filter-arch
branch
from
319c7a7 to
860ca0a
Compare
Add CommandMatcher enum for standardized filter matching with Exact, Prefix, Regex, and Custom variants. Add FilterConfidence (Full/Partial/ Fallback) to FilterResult for tracking filter effectiveness. Implement FilterPipeline for composable multi-stage filtering with worst-confidence aggregation. Add SecurityPatterns with 17 compiled regex patterns across 6 categories (compiler warnings, unsafe code, auth, crypto, injection, advisories) applied at registry level. Add FilterMetrics with in-memory tracking of commands filtered, char savings, and confidence distribution with periodic debug logging. Introduce per-filter TOML configuration (TestFilterConfig, GitFilterConfig, etc.) with max_failures, truncate_stack_trace, max_diff_lines params. 9 files changed, 1551 tests pass. No new dependencies. Closes #439, closes #440, closes #441, closes #442, closes #443, closes #444 Part of epic #446
bug-ops
force-pushed
the
feat/m26.1/output-filter-arch
branch
from
dac90e0 to
c7c5fc0
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Architecture improvements for the Smart Output Filtering system (epic #446).
matches()on trait9 files changed, +1154/-148 lines. New file:
filter/security.rs. No new dependencies.Test plan
cargo clippy --workspace -- -D warningspassescargo clippy --workspace --features tui -- -D warningspassescargo nextest run --workspace --lib --bins— 1551 passed, 9 skippedCloses #439, closes #440, closes #441, closes #442, closes #443, closes #444
Part of epic #446