fix: periodic tick for TUI metrics refresh#453
Merged
Conversation
The TUI event loop blocked on tokio::select! waiting for user input or agent events. When the agent was processing (updating metrics via watch channel), the loop never woke up to poll and redraw, causing stale metrics display. Add a 250ms interval tick branch to select! so metrics are polled and the screen redraws at ~4 Hz regardless of event activity. Closes #447
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tui_loopselect! to ensure metrics polling and screen redraw regardless of user/agent event activityRoot cause
The event loop blocked indefinitely in
tokio::select!on UI and agent channels. Without incoming events,poll_metrics()andterminal.draw()never re-executed, leaving metrics frozen at their initial values.Test plan
cargo run -- --tui, observe Resources panel updates during LLM callsCloses #447