fix: send tool output and diff atomically in native tool_use path#498
Merged
fix: send tool output and diff atomically in native tool_use path#498
Conversation
The DiffReady event was dispatched before the tool message existed in TUI, so diff data had nothing to attach to. Bundle diff and filter stats into a single send_tool_output call on the Channel trait so TUI receives them atomically with the tool message. Closes #497
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send_tool_output()method to Channel trait that bundles tool name, display text, diff data, and filter stats into a single atomic callAgentEvent::ToolOutputinstead of separatesend_diff()+send()calls that racedTest plan
cargo check --workspacepassescargo clippy --workspace -- -D warningscleancargo nextest run --workspace --lib --bins— 1589 tests passCloses #497