fix: skip duplicate send_tool_output for shell-streamed tools#516
Merged
fix: skip duplicate send_tool_output for shell-streamed tools#516
Conversation
Add ToolOutput.streamed flag to indicate tools that already sent their output via ToolEvent channel (shell streaming path). In streaming.rs, skip send_tool_output for these tools to prevent duplicate TUI messages.
Propagate the new ToolOutput.streamed field to all struct initializations across test mocks and executor implementations to fix compilation errors after the duplicate output prevention change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolOutput.streamedflag to indicate tools that already sent output viaToolEventchannel (shell streaming path)send_tool_outputinstreaming.rsfor streamed tools to prevent duplicate TUI messagesstreamed = truewhentool_event_txis available; all other executors default tofalseFollows up on #508 which forwarded
send_tool_outputthrough enum dispatchers but inadvertently caused bash tool output to appear twice in TUI.Test plan
cargo nextest run --workspace --lib --bins