Conversation
github-actions
bot
added
rust
core
dependencies
bug
bug-ops
force-pushed
the
fix/506-tool-schema-doom-loop
branch
from
9f01fe7 to
534d204
Compare
…ve tool calls Remove $schema and title fields from schemars-generated JSON before passing tool definitions to Claude API. Fix doom loop detection that was broken for native tool_use path because tool_use_id uniqueness defeated string comparison — normalize volatile IDs before comparing consecutive messages. Closes #506
bug-ops
force-pushed
the
fix/506-tool-schema-doom-loop
branch
from
534d204 to
9cb4dc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$schemaandtitlefields from schemars-generated JSON before passing tool definitions to Claude API, preventing schema metadata from confusing the model into omitting required parameterstool_use_idvalues before comparing consecutive messagesTest plan
cargo +nightly fmt --checkpassescargo clippy --workspace -- -D warningspassescargo nextest run --workspace --lib --bins— 1596 passed, 0 failedtool_def_strips_schema_and_title,normalize_strips_tool_result_ids,normalize_strips_tool_use_ids,normalize_preserves_plain_text,normalize_handles_mixed_tag_orderCloses #506