fix(cli): restore --vault, --vault-key, --vault-path flags after clap migration#589
Merged
fix(cli): restore --vault, --vault-key, --vault-path flags after clap migration#589
Conversation
… migration Vault CLI flags were lost when argument parsing migrated to clap::Parser. Clap rejected them as unknown arguments before parse_vault_args() could process them via std::env::args(). - Add vault, vault_key, vault_path fields to Cli struct - Refactor AppBuilder::from_env() to AppBuilder::new() with explicit overrides - Refactor parse_vault_args() / resolve_config_path() to accept CLI params - Add ZEPH_VAULT_KEY / ZEPH_VAULT_PATH env var support - Remove is_tui_requested() in favor of clap-parsed cli.tui - Add regression tests for vault flag parsing and priority chain Closes #587
github-actions
bot
added
bug
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--vault,--vault-key,--vault-path) were lost during clap migration; clap rejected them as unknown argumentsAppBuilder::from_env()→AppBuilder::new()with explicit CLI overrides, eliminating manualstd::env::args()parsingZEPH_VAULT_KEY/ZEPH_VAULT_PATHenv var support for key and vault pathsis_tui_requested()in favor of clap-parsedcli.tuiTest plan
cargo +nightly fmt --checkcargo clippy --workspace -- -D warningscargo nextest run --workspace --lib --bins(1878 passed)cargo run -- --vault age --vault-key /tmp/k --vault-path /tmp/vaccepts flags without errorCloses #587