feat(tui): make markdown links clickable via OSC 8 hyperlinks#606
Merged
feat(tui): make markdown links clickable via OSC 8 hyperlinks#606
Conversation
github-actions
bot
added
enhancement
Collect (display_text, url) pairs during pulldown-cmark rendering and merge them into the hyperlink system alongside regex-detected bare URLs. - Add MdLink struct to capture markdown link metadata in MdRenderer - Propagate md_links through render pipeline and cache them in RenderCacheEntry - Single-pass buffer scan in collect_from_buffer_with_md_links merging bare URL regex matches with markdown link spans (dedup on overlap) - Sanitize URLs: strip ASCII control chars before OSC 8 write, reject non-http(s) schemes from markdown links - Use char-indexed search for correct non-ASCII link text handling
bug-ops
force-pushed
the
feat/580-tui-markdown-links
branch
from
bf57dde to
1bdc303
Compare
github-actions
bot
added
enhancement
github-actions
bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(display_text, url)pairs during pulldown-cmark rendering inMdRenderermd_linksinRenderCacheEntryto avoid re-parsing on every frameTest plan
[text](url)renders as clickable OSC 8 hyperlink withtextas display[**bold**](url))[](url)produces no hyperlinkjavascript:/data:/file:schemes rejectedCloses #580