feat(cli): add persistent input history with rustyline#607
Merged
Conversation
github-actions
bot
added
enhancement
Integrate rustyline 17 into CLI channel for readline-style input with persistent history backed by SQLite. Custom SqliteHistory implements rustyline::history::History trait using in-memory VecDeque with async SQLite persistence via Handle::block_on inside spawn_blocking. - Add input_history table migration (010) - Add SqliteStore history CRUD (load/save/clear) - Implement SqliteHistory with prefix search and dedup support - Rewrite CliChannel::recv() and confirm() to use rustyline editor - Wire SqlitePool from memory into channel creation in main.rs
bug-ops
force-pushed
the
feat/604-cli-input-history
branch
from
7ad23fd to
cd071fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #604
SqliteHistoryimplementingrustyline::history::HistorytraitChanges
migrations/010_input_history.sql— newinput_historytablecrates/zeph-memory/src/sqlite/history.rs—load_input_history,save_input_entry,clear_input_historyonSqliteStorecrates/zeph-channels/src/cli.rs—SqliteHistorystruct withVecDeque<String>+SqlitePool;CliChannel::with_history()constructor;recv()/confirm()useeditor.readline()src/main.rs— pre-load history from SQLite, pass pool + entries to channel creationDesign decisions
with-sqlite-historyto avoid addingrusqlite(project usessqlx)Handle::block_on()insidespawn_blockingCliChannel::new()preserved for tests (no editor, falls back to stdin)Test plan
cargo +nightly fmt --checkcargo clippy --workspace -- -D warningscargo nextest run --workspace --lib --bins(1948 passed)cargo run, type messages, exit, restart, press Up — history restored