feat(build): expand full feature set and enable for release builds#610
Merged
feat(build): expand full feature set and enable for release builds#610
Conversation
github-actions
bot
added
enhancement
Add daemon, otel, pdf, scheduler, stt to the full feature flag. Build release binaries with --features full. Fix compilation issues uncovered by the expanded feature set: missing serde_json dep for scheduler, shutdown_rx ownership, WhisperProvider Debug impl, pdf loader clippy warnings, otel tracer cfg gate.
bug-ops
force-pushed
the
feat/full-features-release
branch
from
9b2760c to
20513d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fullfeature flag to include all platform-independent features:daemon,otel,pdf,scheduler,stt(in addition to existinga2a,discord,gateway,index,mock,slack,tui)--features fullfor both native and cross-compilation targetsChanges
Cargo.toml: expandfullfeature, addserde_jsonoptional dep for scheduler.github/workflows/release.yml: add--features fullto build commandssrc/main.rs: fixshutdown_rxmove, addTaskHandlerimport, narrowsetup_otel_tracercfg gatecrates/zeph-llm/src/whisper.rs: usefinish_non_exhaustive()in Debug implcrates/zeph-memory/src/document/loader/pdf.rs: fix clippyimplicit_cloneandio_other_errorTest plan
cargo build --features fullpassescargo clippy --workspace --features full -- -D warningscleancargo nextest run --workspace --features full --lib --bins— 2117 passed