fix(memory): add wait(true) to Qdrant upsert and delete operations#611
Merged
fix(memory): add wait(true) to Qdrant upsert and delete operations#611
Conversation
github-actions
bot
added
bug
Qdrant upsert/delete are async by default, returning before points are indexed. This caused flaky integration tests where scroll queries executed before inserted points became visible. Add .wait(true) to UpsertPointsBuilder and DeletePointsBuilder to ensure read-after-write consistency. Closes #567
bug-ops
force-pushed
the
fix/567-flaky-ingested-chunks-test
branch
from
801a777 to
02a62a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.wait(true)toUpsertPointsBuilderandDeletePointsBuilderinQdrantOpsto ensure read-after-write consistencyingested_chunks_have_correct_payloadintegration testTest plan
cargo clippy --workspace -- -D warningspassescargo +nightly fmt --checkpassescargo nextest run --workspace --lib --bins— 2011 passed, 0 failedCloses #567