fix(tui): prevent event reader thread termination on mouse events#614
Merged
fix(tui): prevent event reader thread termination on mouse events#614
Conversation
… events CrosstermEventSource::next_event() returned None for mouse events other than scroll (click, drag, move) and for unhandled crossterm events (FocusGained, FocusLost, Paste). Since EventReader::run_with_source() exits its loop on None, any mouse click killed the event reader thread, making the TUI unresponsive to all keyboard input. Return AppEvent::Tick instead of None for ignored events to keep the reader thread alive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CrosstermEventSource::next_event()returnedNonefor non-scroll mouse events and unhandled crossterm events (FocusGained/FocusLost/Paste), which terminated theEventReader::run_with_source()loopNonewithAppEvent::Tickto keep the reader thread aliveTest plan
cargo +nightly fmt --checkcargo clippy --workspace -- -D warningscargo nextest run --workspace --lib --bins(2014 passed)