feat(tools): harden shell command detection against bypass vectors#668
Merged
feat(tools): harden shell command detection against bypass vectors#668
Conversation
Replace substring-based blocked command matching with tokenizer pipeline: strip_shell_escapes normalizes backslash, hex/octal ($'\xNN'/'\NNN'), and quote-split bypasses; tokenize_commands splits on pipes, operators, and semicolons; tokens_match_pattern performs word-boundary matching with basename extraction and transparent prefix skipping. Use std::path::absolute() as canonicalize fallback for non-existent paths in sandbox validation. Closes #618
github-actions
bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$'\xNN', octal$'\NNN', quote splitting) and splits on shell operators before word-boundary matching/usr/bin/sudois correctly blockedenv,command,exec,nice,nohup,time,xargs) to detect actual commandstd::path::absolute()as fallback whencanonicalize()fails on non-existent paths in sandbox validation$(and backtick subshell expressions to default confirm patternsTest plan
cargo nextest run -p zeph-tools --lib)cargo +nightly fmt --checkcleancargo clippy --workspace -- -D warningscleanCloses #618,Closes #628,Closes #629