refactor: box Image variant and erase ToolExecutor generic from Agent#677
Merged
refactor: box Image variant and erase ToolExecutor generic from Agent#677
Conversation
github-actions
bot
added
documentation
bug-ops
force-pushed
the
feat/625-memory-layout-optimization
branch
from
92f7c0b to
497efe0
Compare
bug-ops
force-pushed
the
feat/625-memory-layout-optimization
branch
2 times, most recently
from
431af10 to
8662db5
Compare
Box<ImageData>, reducing enum variant size from 48 to 8 bytes. Update all construction and pattern match sites across providers, agent, and tests. Add ErasedToolExecutor object-safe trait with boxed futures as a blanket impl over ToolExecutor. Agent now stores Box<dyn ErasedToolExecutor>, simplifying all impl blocks and removing monomorphization noise.
bug-ops
force-pushed
the
feat/625-memory-layout-optimization
branch
from
8662db5 to
71c0402
Compare
Remove obsolete second generic argument from Agent<MockChannel, ShellExecutor> to match the simplified Agent<C> signature after ToolExecutor erasure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MessagePart::Imagedata intoImageDatastruct — cleaner semantics for heap-allocated image payloadsT: ToolExecutorgeneric fromAgent<C, T>— replaced withBox<dyn ErasedToolExecutor>to reduce monomorphization and simplify all impl blocksCloses #625, closes #657, closes #660
Changes
crates/zeph-llm/src/provider.rs—ImageDatastruct,Image(Box<ImageData>)variantcrates/zeph-tools/src/executor.rs—ErasedToolExecutortrait with blanket implcrates/zeph-core/src/agent/—Agent<C>without T, 8 impl files updatedcrates/zeph-llm/src/claude.rs,ollama.rs,openai.rs— Image construction updatedsrc/main.rs— simplified Agent constructionTest plan