Conversation
…ted body content Add validate_skill_references() to detect broken or path-traversal Markdown links in skill bodies (references/, scripts/, assets/ subdirs). Warns via tracing::warn! without blocking skill load. Add sanitize_skill_body() with case-insensitive replacement of XML structural tags (skill, instructions, available_skills) to prevent prompt injection from untrusted skills. Applied in format_skills_prompt() for all non-Trusted trust levels; Quarantined skills are sanitized before wrapping. Closes #689
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_skill_references()— parses Markdown links targeting references/, scripts/, assets/ and warns about missing or traversal pathssanitize_skill_body()— escapes XML structural tags (case-insensitive) for skills with trust != trustedCloses #689
Test plan
cargo nextest run --workspace --lib --bins— 2239 tests passcargo clippy --workspace -- -D warnings— cleancargo +nightly fmt --check— clean