Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate output-http non-compatible clients #833

Merged
merged 7 commits into from
Oct 13, 2020

Conversation

urbanishimwe
Copy link
Collaborator

@urbanishimwe urbanishimwe commented Oct 11, 2020

for easy readability check changes by their underlying commits!

these benchmarks address the whole operation of the request cycle in goreplay.

goos: linux
goarch: amd64

Using Compatible client:

BenchmarkHTTPOutput-4      	   10417	    118969 ns/op	   12172 B/op	      93 allocs/op
BenchmarkHTTPOutputTLS-4   	    9136	    132929 ns/op	   12448 B/op	      97 allocs/op

Using non-compatible client

BenchmarkHTTPOutput-4      	     859	   1175040 ns/op	   15598 B/op	      46 allocs/op
BenchmarkHTTPOutputTLS-4   	     880	   1189643 ns/op	   15544 B/op	      52 allocs/op

Binary size reduced: 7%

from these benchmarks, we may trade allocations with performance and memory!

@urbanishimwe urbanishimwe force-pushed the output-http-compatible-only branch from a77e27f to 0a77450 Compare October 12, 2020 06:45
@urbanishimwe urbanishimwe force-pushed the output-http-compatible-only branch from 0a77450 to dbc6832 Compare October 12, 2020 07:11
@urbanishimwe urbanishimwe requested a review from buger October 12, 2020 07:26
@buger
Copy link
Owner

buger commented Oct 12, 2020

That's not the only change, right?

I see new flags for HTTP client.

@urbanishimwe
Copy link
Collaborator Author

That's not the only change, right?

I see new flags for HTTP client.

Yes, I added some flags to provide more flexibility, here is more detailed issues

@buger
Copy link
Owner

buger commented Oct 13, 2020

Looks good!

@buger buger merged commit 5d8ca52 into master Oct 13, 2020
@buger buger deleted the output-http-compatible-only branch October 13, 2020 05:36
xingren23 referenced this pull request in xingren23/goreplay Sep 4, 2021
for easy readability check changes by their underlying commits!

these benchmarks address the whole operation of the request cycle in goreplay.

_**goos: linux
goarch: amd64**_

**Using Compatible client:**

```
BenchmarkHTTPOutput-4      	   10417	    118969 ns/op	   12172 B/op	      93 allocs/op
BenchmarkHTTPOutputTLS-4   	    9136	    132929 ns/op	   12448 B/op	      97 allocs/op
```

**Using non-compatible client**
```
BenchmarkHTTPOutput-4      	     859	   1175040 ns/op	   15598 B/op	      46 allocs/op
BenchmarkHTTPOutputTLS-4   	     880	   1189643 ns/op	   15544 B/op	      52 allocs/op

```
Binary size reduced: **7%**

from these benchmarks, we may trade allocations with performance and memory!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--output-http stopped working in 1.2.0 HTTP dynamic worker scaling is broken in 1.0
2 participants