Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocommit and TransactionIsolation Support for Transactions #121

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

vnayar
Copy link
Contributor

@vnayar vnayar commented Dec 11, 2023

This is preparatory work before higher level transaction support can be added to HibernateD.
The function names and types used are based on https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html

Tests were expanded and a few uncaught bugs in the implementation of setAutoCommit were found and fixed.

The included .editorconfig is a copy of the file from HibernateD.

Copy link
Collaborator

@SingingBush SingingBush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. The ddbctest/main is getting rather large so may be worth splitting into multiple files for different kinds of tests. That doesn't have to be done now though. I'm happy to merge if the writeln can be changed to use standard logger

@SingingBush SingingBush merged commit c043e9e into buggins:master Dec 13, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants