Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EditLine doesn't scroll when selecting text with mouse #645

Closed
GrimMaple opened this issue Dec 16, 2022 · 1 comment · Fixed by #674
Closed

EditLine doesn't scroll when selecting text with mouse #645

GrimMaple opened this issue Dec 16, 2022 · 1 comment · Fixed by #674
Labels
bug

Comments

@GrimMaple
Copy link
Collaborator

No description provided.

@GrimMaple GrimMaple added the bug label Dec 16, 2022
@Ermiq Ermiq mentioned this issue Sep 14, 2023
Merged
GrimMaple pushed a commit that referenced this issue Sep 15, 2023
@Ermiq
Fix #645, fix #673 (#674)
5fcb652 
* fix #645, fix #673

Fix #673 where the function `renameTab(string ID, dstring name)` in `src/dlangui/widgets/tabs.d` failed to find the tab with the given id because it uses the `TabControl`'s own id due to the misuse of lower/upper case names. Changed the function's argument `ID` that have never been used to `id`.  
  
Fix #645 where `EditWidgetBase` doesn't scroll when mouse selection is active and the cursor goes beyond the widget boundaries. Now it scrolls.  
Additionally, added new type of `EditorActions` to make 2 different types of `EditorActions.ScrollLineUp/Down`. The old `ScrollLineUp/Down` made 3 lines scrolling and it doesn't work well with new mouse selection scrolling when out of bounds (scrolls too fast). So now there are `ScrollLineUp/DownSingle` and `ScrollLineUp/DownTriple`. The single one is used by the mouse selection scrolling, the triple one used in all other cases just like before.

* Original ScrollLineUp + ScrollLineUpSingle
@GrimMaple
Copy link
Collaborator Author

I am reopening this because horizontal scrolling is still not working

@GrimMaple GrimMaple reopened this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #645, fix #673
1 participant
@GrimMaple