Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mouse event processing for ListWidget adapter children #690

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

whitebyte
Copy link
Contributor

@whitebyte whitebyte commented Nov 9, 2024

Fixes #538

Disclaimer:

  1. I only checked it with mouse events, not keyboard events
  2. Git history shows that this line was never uncommented, it was added in b07d0aa already commented out. The commit was introduced in Tooltips are not shown #303. There, @buggins states: "No mouse events are being passed to items in list widget. List handles them all.". I examined widget.d and see that it's only partially true. ListWidget indeed manages its children hover/selected state, but that's it. There are use cases when it's not enough, e.g. I want to open a popup menu by right-clicking a ListWidget child added through adapter.

Uncommenting the line fixes the issue for me and looks like a straingtforward thing to do, but then again I don't know what was @buggins ' motivation and design goals there. So, proceed with caution

@GrimMaple GrimMaple merged commit 3c38f32 into buggins:master Nov 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListWidget + WidgetListAdapter = child widgets don't work
2 participants