Add initial support for @EmbeddedId, permitting composite keys. #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More work will be needed to support @onetomany and @manytoone using a composite key, the JPA @JoinColumns annotation will be needed to support this. However, with this change, at least some options exist for dealing with composite-keys rather than just facing a brick wall.
|
@SingingBush Let me know if there are any gaps or things to be added before this can be merged. There are a few gaps that I'm aware of at the moment including:
However, the feature adds value even in its current form, as it allows representation of existing databases that use compound keys, something not possible before. |
|
The limitations seem ok as long as it's clearly documented. Could you add some details to the readme about the support for composite keys. |
|
README updated with notes about the current state of implementation. More work will of course come to address these shortcomings as time permits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work will be needed to support @onetomany and @manytoone using a composite key, the JPA @JoinColumns annotation will be needed to support this. However, with this change, at least some options exist for dealing with composite-keys rather than just facing a brick wall.
See #85