Removed onViewLoadLeak trigger for Activity.onStop #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YYChen01988
force-pushed
the
PLAT-11639/Activity.onStop_should_not_trigger_span_leak_detection
branch
from
dce0307
to
447e5b2
Compare
Android notifier sizes
Generated by 🚫 Danger |
lemnik
reviewed
Mar 18, 2024
...com/bugsnag/android/performance/internal/instrumentation/ActivityLifecycleInstrumentation.kt
Outdated
Show resolved
Hide resolved
YYChen01988
force-pushed
the
PLAT-11639/Activity.onStop_should_not_trigger_span_leak_detection
branch
from
447e5b2
to
e6d8830
Compare
lemnik
changed the title
YYChen01988
force-pushed
the
PLAT-11639/Activity.onStop_should_not_trigger_span_leak_detection
branch
from
e6d8830
to
213cc8b
Compare
lemnik
approved these changes
Mar 19, 2024
YYChen01988
force-pushed
the
PLAT-11639/Activity.onStop_should_not_trigger_span_leak_detection
branch
from
213cc8b
to
7cf4e89
Compare
YYChen01988
deleted the
PLAT-11639/Activity.onStop_should_not_trigger_span_leak_detection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Auto-instrumented spans should only be considered “leaked” when the
Activityis destroyed, since theActivitymay stop and restart while the span is still valid (for example when backgrounded briefly).Changeset
Removed
onViewLoadLeakfromActivity.onStopinstrumentation