Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump compileSdkVersion to apiLevel 31 #1536

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Bump compileSdkVersion to apiLevel 31 #1536

merged 1 commit into from
Nov 30, 2021

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Nov 29, 2021 •
edited
Loading

Goal

Bumps the compileSdkVersion to apiLevel 31 from 30. This ensures that our SDK is compiled against the latest version of Android while retaining compatibility for previously supported versions.

Changeset

  • Bumped compileSdkVersion to 31
  • Bumped targetSdkVersion where possible (bugsnag-benchmarks is the only place still targetting 30, as the microbenchmark library does not support this yet)
  • Avoided closing the system dialogs in the mazerunner fixture as this is no longer allowed in Android 12

Testing

Relied on existing test coverage and ran the example app.

@fractalwrench fractalwrench changed the title Bump compileSdkVersion to 31 Bump compileSdkVersion to apiLevel 31 Nov 29, 2021
@fractalwrench fractalwrench force-pushed the PLAT-7652/bump-compile-sdk-version branch from 1dc6f48 to 7a1072d Compare November 29, 2021 15:16
@bugsnagbot
Copy link
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1353.23 1168.01
arm64_v8a 483.72 299.4
armeabi -492.59 -21.55
armeabi_v7a 455.06 270.74
x86 520.57 340.35
x86_64 508.29 323.97

Generated by 🚫 Danger

@fractalwrench fractalwrench force-pushed the PLAT-7652/bump-compile-sdk-version branch from 7a1072d to 29b842d Compare November 29, 2021 15:45
@fractalwrench fractalwrench marked this pull request as ready for review November 29, 2021 16:54
lemnik
lemnik approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Pending a Rebase. The CHANGELOG entry might need to be moved post v5.16.0

@fractalwrench fractalwrench force-pushed the PLAT-7652/bump-compile-sdk-version branch from 29b842d to 12e53bf Compare November 30, 2021 09:56
@fractalwrench fractalwrench merged commit 64fdd05 into next Nov 30, 2021
@fractalwrench fractalwrench deleted the PLAT-7652/bump-compile-sdk-version branch November 30, 2021 13:09
@djskinner djskinner mentioned this pull request Jan 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemnik lemnik lemnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fractalwrench @bugsnagbot @lemnik