Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-12988] Set bugsnag.span.category to 'custom' for custom spans #336

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

kstenerud
Copy link
Contributor

Custom spans now set attribute bugsnag.span.category to custom.

e2e tests have been updated to check for this.

Copy link

github-actions bot commented Oct 29, 2024

BugsnagPerformance.framework binary size increased by 232 bytes from 518,216 to 518,448

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.3%    +292  +0.3%    +292    __TEXT,__text
  +0.1%    +112  +0.1%    +112    String Table
  +0.1%    +112  +0.1%    +112    Symbol Table
  +0.5%     +56  +0.5%     +56    __TEXT,__gcc_except_tab
  +0.4%     +32  +0.4%     +32    __DATA_CONST,__cfstring
  +0.5%     +24  +0.5%     +24    __TEXT,__unwind_info
  +0.7%      +8  +0.7%      +8    Function Start Addresses
  +0.1%      +7  +0.1%      +7    __TEXT,__cstring
  -1.4%     -32  -1.4%     -32    [__DATA_CONST]
  [ = ]       0  -3.8%    -232    [__LINKEDIT]
  -0.8%    -379  -0.8%    -379    [__TEXT]
  +0.0%    +232  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud force-pushed the PLAT-12988-custom-span-attributes branch from 553779a to fee18bf Compare October 29, 2024 12:35
tomlongridge
tomlongridge previously approved these changes Oct 29, 2024
@kstenerud kstenerud merged commit 9b6b965 into next Oct 30, 2024
26 checks passed
@kstenerud kstenerud deleted the PLAT-12988-custom-span-attributes branch October 30, 2024 13:43
This was referenced Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants