Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startSpan method to crosstalk API #342

Conversation

yousif-bugsnag
Copy link

Goal

Add support for starting spans via the crosstalk API

Testing

Added a unit test for the new crosstalk API method and tested manually via React Native Performance

Copy link

github-actions bot commented Nov 4, 2024

BugsnagPerformance.framework binary size increased by 560 bytes from 519,736 to 520,296

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.5%    +532  +0.5%    +532    __TEXT,__text
  +0.3%    +304  +0.3%    +304    Symbol Table
  +0.2%    +256  +0.2%    +256    String Table
  +0.7%    +120  +0.7%    +120    __DATA,__objc_const
  +0.7%    +106  +0.7%    +106    __TEXT,__objc_methname
  +2.4%     +71  +2.4%     +71    __TEXT,__objc_methtype
  +0.5%     +64  +0.5%     +64    __TEXT,__objc_stubs
  +0.3%     +40  +0.3%     +40    __TEXT,__gcc_except_tab
  +0.4%     +32  +0.4%     +32    __DATA_CONST,__cfstring
  +0.7%     +24  +0.7%     +24    __DATA,__objc_selrefs
  +0.5%     +24  +0.5%     +24    __TEXT,__unwind_info
  +0.2%     +12  +0.2%     +12    __TEXT,__cstring
  +0.9%      +4  +0.9%      +4    __DATA,__objc_ivar
  -1.4%     -32  -1.4%     -32    [__DATA_CONST]
  -2.1%    -148  -2.2%    -148    [__DATA]
  [ = ]       0 -12.3%    -560    [__LINKEDIT]
  -1.8%    -849  -1.8%    -849    [__TEXT]
  +0.1%    +560  [ = ]       0    TOTAL

Generated by 🚫 Danger

@yousif-bugsnag yousif-bugsnag merged commit 6058746 into integration/react-native-integration Nov 8, 2024
24 checks passed
@yousif-bugsnag yousif-bugsnag deleted the PLAT-12931/start-span-crosstalk-api branch November 8, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants