Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plat 7627 window descriptions #1238

Merged
merged 2 commits into from
Nov 25, 2021
Merged

Plat 7627 window descriptions #1238

merged 2 commits into from
Nov 25, 2021

Conversation

kstenerud
Copy link
Contributor

@kstenerud kstenerud commented Nov 24, 2021

Goal

PLAT-7627

Add more information to window-oriented breadcrumbs.

Design

Grab the window description, title, subtitle, and view controller information and include them in the metadata for window-related breadcrumbs.

Testing

  • New unit tests
  • Manual testing

@kstenerud kstenerud force-pushed the PLAT-7627-window-descriptions branch 3 times, most recently from 0745b0c to 581ce7a Compare November 24, 2021 11:07
@github-actions
Copy link

github-actions bot commented Nov 24, 2021

Infer: No issues found 🎉

OCLint: No issues found 🎉

Bugsnag.framework binary size increased by 1,472 bytes from 1,254,872 to 1,256,344

Generated by 🚫 Danger

@kstenerud kstenerud marked this pull request as ready for review November 24, 2021 14:23
Copy link
Contributor

@nickdowell nickdowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test cases should be added to BSGNotificationBreadcrumbsTests to cover these new breadcrumbs.

Bugsnag/Helpers/BSGUtils.h Outdated Show resolved Hide resolved
Copy link
Contributor

@nickdowell nickdowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'APPROVE' performed by Xcode.

@kstenerud kstenerud merged commit e7898f2 into next Nov 25, 2021
@kstenerud kstenerud deleted the PLAT-7627-window-descriptions branch November 25, 2021 13:07
@nickdowell nickdowell mentioned this pull request Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants