[PLAT-10016] Use original unhandled value for persisting user-reported events #1549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Use the original unhandled state of an event and not the overridden unhandled value when determining whether to store an event or upload immediately.
This is more representative of whether the runtime is about to crash, rather than what the developer has changed it to (which is more likely to do with their stability score).
Changeset
originalUnhandledValue
toBugsnagHandledState
that uses theunhandledOverridden
flag to determine the original handled-ness of the event.notifyInternal
to checkoriginalUnhandledValue
when deciding whether to persist an event or send immediatelyTesting
originalUnhandledValue
onError
block