fix: Parse system info from root if no nested system dictionary exists #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin308
approved these changes
Jul 16, 2018
|
|
||
| BSGDictSetSafeObject(app, system[@"CFBundleVersion"], @"bundleVersion"); | ||
| BSGDictSetSafeObject(app, report[@"CFBundleVersion"], @"bundleVersion"); |
There was a problem hiding this comment.
should bundleVersion be a const like the other keys? BSGKeyReleaseStage etc.
There was a problem hiding this comment.
Maybe; I want to think about how we are doing key constants a bit in the meantime in case there's an easy way to both define and find the right ones.
In reports, the base report has a “system” dict for system info. Sessions rely on the raw info parser to gather app and device data, which is not nested in a separate “system” dict. Added additional tests for app versions
kattrali
force-pushed
the
kattrali/session-verify-app-version
branch
from
70d16ff
to
861b493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reports, the base report has a “system” dict for system info.
Sessions rely on the raw info parser to gather app and device data,
which is not nested in a separate “system” dict.
Goal
The changes in #292 fixed sending a custom version for reports but
broke app version parsing for sessions. This change refactors app
state parsing slightly to ensure both reports and sessions fetch the
correct app state (and custom versions, if provided).
Changeset
Moved the top level version parsing out to error reports from
BSGParseAppState. The preferred app version is now (optionally) specified up front.Tests
Added new integration test cases for verifying app version with or without custom versions set.
Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: