Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The
app.name
field was removed during recent work to create structured objects. This change reinstates it. the value is sourced fromCFBundleExecutable
.Design
A simple search for all
app.*
-referencing locations (e.g.app.id
) and insertion of suitable code.Changeset
Tests
Non-nil-checking unit tests were already present. Manual testing that the app name is sent through to the appropriate tab on the dashboard were performed.
Review
Outstanding Questions
master
for fixes,next
forfeatures)