Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate app.name field #600

Merged
merged 7 commits into from
May 18, 2020
Merged

Reinstate app.name field #600

merged 7 commits into from
May 18, 2020

Conversation

robinmacharg
Copy link
Contributor

Goal

The app.name field was removed during recent work to create structured objects. This change reinstates it. the value is sourced from CFBundleExecutable.

Design

A simple search for all app.*-referencing locations (e.g. app.id) and insertion of suitable code.

Changeset

Tests

Non-nil-checking unit tests were already present. Manual testing that the app name is sent through to the appropriate tab on the dashboard were performed.

Review

Outstanding Questions

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
    • Release
  • The correct target branch has been selected (master for fixes, next for
    features)
  • If this is intended for release have all of the pre-release checks been considered?
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@robinmacharg robinmacharg marked this pull request as ready for review May 14, 2020 15:39
@robinmacharg robinmacharg merged commit cd2874d into v6 May 18, 2020
@robinmacharg robinmacharg deleted the v6-reinstate-app-name branch May 18, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants