Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(breadcrumbs): updated outdated docs for BugsnagBreadcrumbs.arrayValue #748

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

tomlongridge
Copy link
Contributor

Goal

As per #747, the docs on BugsnagBreadcrumbs.arrayValue were out of date as they now return an array of dictionaries, not strings.

@tomlongridge tomlongridge merged commit 636e985 into next Jul 9, 2020
@tomlongridge tomlongridge deleted the tom/update-bugsnagbreadcrumbs-arrayvalue-docs branch July 9, 2020 09:44
@snmaynard
Copy link
Contributor

@tomlongridge should we not document the keys?

@tomlongridge
Copy link
Contributor Author

tomlongridge commented Jul 9, 2020

@tomlongridge should we not document the keys?

This is an internal method, so I didn't think it was necessary as it will change with the structure of the BugsnagBreadcrumb class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BugsnagBreadcrumbs.arrayValue returns NSArray<NSDictionary*> * not NSArray<NSString*> * as documented
3 participants