Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-8762] Add maxStringValueLength #179

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

nickdowell
Copy link
Contributor

Goal

Allow truncation behaviour to be configured.

Changeset

Adds maxStringValueLength to bugsnag.start.

Passes value through to Android & Cocoa notifiers.

Improve compile-time safety of key-value-coding for Cocoa.

Testing

Used example app and debugger to verify that value is passed through.

@nickdowell nickdowell requested a review from lemnik November 3, 2022 13:43
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickdowell nickdowell merged commit e1e78bf into next Nov 7, 2022
@nickdowell nickdowell deleted the nickdowell/max-string-value-length branch November 7, 2022 09:41
@lemnik lemnik mentioned this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants