Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run builds against Gin + Go 1.8/1.9 #121

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Don't run builds against Gin + Go 1.8/1.9 #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ jobs:
script: make ci
go: "1.7"
- script: make ci
env: GO_VERSION=1.8
go: "1.8"
- script: make ci
env: GO_VERSION=1.9
go: "1.9"
- script: make ci
go: "1.10"
Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ updatedeps:
test: alldeps
@#TODO: 2018-09-20 Not testing the 'errors' package as it relies on some very runtime-specific implementation details.
@# The testing of 'errors' needs to be revisited
@# Additionally skipping Gin if the Go version is 1.7, as the latest version of Gin has dropped support.
@if [ "$(GO_VERSION)" = "1.7" ]; then \
@# Additionally skipping Gin if the Go version is lower than 1.9, as the latest version of Gin has dropped support for these versions.
@if [ "$(GO_VERSION)" = "1.7" ] || [ "$(GO_VERSION)" = "1.8" ] || [ "$(GO_VERSION)" = "1.9" ]; then \
go test . ./martini ./negroni ./sessions ./headers; \
else \
go test . ./gin ./martini ./negroni ./sessions ./headers; \
Expand Down