[fix] Ensure fatal panics are notified #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a bug in the existing `notifier.NotifySync` method, we end up using the notifier's config value to determine whether to send synchronously or async. In the case of a fatal panic (i.e not `AutoNotified` or `Recover`-ed) it still got sent asynchronously. This change ensures that it does get sent synchronously.
kattrali
previously approved these changes
Oct 2, 2018
kattrali
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in the existing
notifier.NotifySyncmethod, we end upusing the notifier's config value to determine whether to send
synchronously or async. In the case of a fatal panic (i.e not
AutoNotifiedorRecover-ed) it still got sent asynchronously.This change ensures that it does get sent synchronously.
Tested by putting a panic immediately after the Bugsnag configuration, and seeing if it got reported.