Skip to content

Commit

Permalink
Pin karma dependency to version that works with old IE
Browse files Browse the repository at this point in the history
As outlined in the linked issue, it looks like our loose version
range allowed a newer Karma to be install that breaks in old IEs.

Karma issue tracker link:
karma-runner/karma#2556

For now, pinning to 1.3.0 resolves a transitive dependency tree
which "works".
  • Loading branch information
bengourley committed Aug 30, 2017
1 parent 96a139b commit 11d62d0
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
9 changes: 6 additions & 3 deletions karma-common.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
var browsers = require('./browsers.json');

var MINUTE_IN_MS = 1000 * 60
var MAX_TIMEOUT = 2 * MINUTE_IN_MS

module.exports = {
basePath: "",
port: 9876,
Expand All @@ -18,9 +21,9 @@ module.exports = {
"/jquery": "/base/test/jquery"
},
concurrency: 1,
captureTimeout: 100000,
browserDisconnectTimeout: 100000,
browserNoActivityTimeout: 100000,
captureTimeout: MAX_TIMEOUT,
browserDisconnectTimeout: MAX_TIMEOUT,
browserNoActivityTimeout: MAX_TIMEOUT,
customLaunchers: browsers,
browsers: [],
reporters: [ "progress", "saucelabs" ],
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"types": "src/bugsnag.d.ts",
"scripts": {
"lint": "grunt eslint",
"test": "karma start --single-run && karma start karma-legacy.conf.js --single-run",
"test": "karma start karma-legacy.conf.js --single-run && karma start --single-run",
"test:watch": "karma start --browsers PhantomJS",
"test:quick": "karma start --single-run --browsers PhantomJS"
},
Expand All @@ -36,7 +36,7 @@
"grunt-regex-replace": "~0.2.5",
"grunt-s3": "git://github.com/pifantastic/grunt-s3",
"gruntify-eslint": "^1.3.0",
"karma": "^1.3.0",
"karma": "1.3.0",
"karma-coverage": "^1.1.1",
"karma-coveralls": "^1.1.2",
"karma-mocha-ie-legacy": "file:./test/karma-mocha",
Expand Down

0 comments on commit 11d62d0

Please sign in to comment.