Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop legacy peer dependencies #2214

Open
wants to merge 5 commits into
base: next
Choose a base branch
from
Open

Drop legacy peer dependencies #2214

wants to merge 5 commits into from

Conversation

yousif-bugsnag
Copy link
Contributor

@yousif-bugsnag yousif-bugsnag commented Oct 3, 2024

Goal

Drop legacy peer dependencies

Design

No longer required after dropping package-lock files from sub-packages and updating dependencies.

Changeset

remove use of --legacy-peer-deps flag in all build files (except the electron ci step), and remove the .npmrc file from the repo.

Removed all unnecessary unit-test related files and dependencies from the angular test fixture as these were causing conflicts and are not required for our tests.

legacy-peer-deps is still required in a couple of places:

  • browser webpack3 test fixture - older version of webpack causes a conflict, so added a .npmrc with legacy-peer-deps=true to the test fixture directory
  • Electron e2e tests - there still seems to be a dependency conflict when installing the packages from local verdaccio into the test fixture, so reinstated legacy-peer-deps in test/electron/features/support/app.js for now. I think this has to do with lockfiles in the packages, but will investigate/PR that separately to keep the PR size manageable

Testing

full ci build

Copy link

github-actions bot commented Oct 3, 2024

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 45.76 kB 13.77 kB
After 45.76 kB 13.77 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 1648634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants