Refactor delivery-xml-http-request #2256
Merged
+46
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerbenw
changed the base branch from
integration/typescript
to
PLAT-13092/delivery-x-domain-request
gingerbenw
force-pushed
the
PLAT-13093/delivery-xml-http-request
branch
from
870e967
to
a5fb684
Compare
gingerbenw
force-pushed
the
PLAT-13093/delivery-xml-http-request
branch
from
a5fb684
to
60c1586
Compare
gingerbenw
changed the title
|
In delivery.test.ts file change the import for delivery. Locally the tests are failing ¯_(ツ)_/¯ |
|
@AnastasiiaSvietlova did you run |
|
no... let me try again to check. |
AnastasiiaSvietlova
approved these changes
Nov 22, 2024
Base automatically changed from
PLAT-13092/delivery-x-domain-request
to
integration/typescript
November 22, 2024 16:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Convert source code to TypeScript and export both es modules and common js modules
Testing
Covered by existing test suite