This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
Handle and report invalid notify(err) argument. Fixes #110. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some examples of this in use: Log output
Dashboard
|
bengourley
force-pushed
the
handle-bad-input
branch
3 times, most recently
from
cef7f12 to
c539c53
Compare
notify(err…) now catches and reports the case where err=null|undefined|0|true|false. An error-level log is printed and Error is constructed and sent to Bugsnag with the offending parameter. All of the arguments are captured and sent in the report's metadata too, to help provide context for when this happens.
bengourley
force-pushed
the
handle-bad-input
branch
from
c539c53 to
432a3e4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notify(err…)now catches and reports the case whereerr=null|undefined|0|true|false.An error-level log is printed and Error is constructed and sent to Bugsnag with the offending parameter. All of the arguments are captured and sent in the report's metadata too, to help provide context for when this happens.