New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #786

Merged

imjoehaines merged 2 commits into master from fix-ci

Jul 19, 2023

Contributor

imjoehaines commented Jul 19, 2023

Goal

We currently have two failures on CI:

a transitive dependency (Loofah) in the Rails 3, 4 & 5 bumped their minimum Ruby & Nokogiri versions, which causes a crash on Ruby < 2.5 and older Nokogiris
Ruby 2.2 no longer works on the ubuntu-latest GH runner

imjoehaines added 2 commits

July 19, 2023 08:39


          Install compatible Loofah version

612c510


          Run Ruby 2.2 on Ubuntu 20.04

See
ruby/setup-ruby#496 (comment)

imjoehaines requested a review from tomlongridge

July 19, 2023 07:43

tomlongridge approved these changes

View reviewed changes

imjoehaines merged commit 90ef7dd into master

imjoehaines deleted the fix-ci branch

July 19, 2023 09:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet