darwin: use Go type wrappers to avoid declaring Go methods on C types. #163
Conversation
|
cc @cmaglie 😸 |
…go-serial#163 is merged Signed-off-by: deadprogram <ron@hybridgroup.com>
|
Sorry to be a pest but Go 1.21 rc4 is now out, so probably the final release is coming anytime. Any chance to getting this reviewed, please? 😸 |
There was a problem hiding this comment.
Hi @deadprogram, thank you very much for the PR!
I've posted some change requests to improve readability, I think we could simplify the overall patch. Let me know what do you think.
|
Hi @deadprogram I've pushed more commits with the changes I proposed in this PR. I tested it and seems to work fine. I'll keep the change here for a couple of days for you to check, and eventually merge them. |
|
Thanks for the refinements @cmaglie at first glance it looks good. I will check it out in more detail this evening and get back to you. |
|
Thank you for the additions @cmaglie let's merge and release please! |
This is needed starting with Go 1.21 due to stricter enforcement of rules about adding methods to existing types, now including C types. See golang/go#60725 for further details. Signed-off-by: deadprogram <ron@hybridgroup.com>
This makes easier the boxing/unboxing of the wrapped types.
cmaglie
force-pushed
the
define-darwin-cgo-types
branch
from
a051ef6 to
1e13b2f
Compare
This is needed starting with Go 1.21 due to stricter enforcement of rules about adding methods to existing types, now including C types. It should fix #162
See golang/go#60725 for further details.