Added NormalizedString to be used as key in maps #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it's useful to have a map like
map[string]*Release
that maps a version to the corresponding release. Anyway, this has a drawback, if the version is not normalized before being assigned as a key we may end up having something like:where two different entries are present for the same version.
To avoid this kind of problem this PR adds a new type
NormalizedString
, so the previous map can be rewritten asmap[semver.NormalizedString]*Release
. To obtain the normalized string the methodVersion.NormalizedString()
can be used.it also helps with a compile-time sanity check on code doing the wrong thing: